Add z-index to Tribute configuration #307
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now z-index was set it two places:
z-index: 999999;
)z-index: 10000;
)It was impossible to override hardcoded value without using
!important
declaration.My case:
I have a modal that has
z-index: 900000;
and I want to show menu container over my modal. I have to override basic tribute styles and add!important
(which is not the best practice):My solution is adding zIndex to Tribute config, by default, it is set to10000
as it was before, so it should not break anything.I removed hardcoded
z-index
value fromtribute menu container
.